Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Brightcove API dependency #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fureigh
Copy link
Contributor

@fureigh fureigh commented May 4, 2018

This was added in #78 as part of Brightcove integration but appears to have fallen out of composer.json somewhere along the way.

For further context, see https://pronovix.com/blog/brightcove-video-connect-drupal-8-part-2-installation-configuration.

This was added in #78 as part of Brightcove integration but
appears to have fallen out of composer.json somewhere along the
way.

For further implementation context, see
https://pronovix.com/blog/brightcove-video-connect-drupal-8-part-2-installation-configuration.
Copy link
Contributor

@cmc333333 cmc333333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running "Sync All" from the Brightcove page locally prior to these dependency changes and it ran without an error. The composer.lock file doesn't add any new libraries (though it does bump up the version of many -- mayhaps you ran composer update?).

Are we sure we need this? It seems like we should already be grabbing these dependencies by referencing brightcove, despite their guidance. I'd prefer to handle dependencies without the merge plugin, if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants